Fix volume_threshold severity example and document warn/error behavior#2120
Merged
Fix volume_threshold severity example and document warn/error behavior#2120
Conversation
- Remove misleading config.severity: error from example - Add "How severity levels work" section explaining the built-in dual severity (warn_if/error_if) behavior - Add warning about not overriding with config.severity Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
config.severity: errorfrom the custom thresholds example (it overrides the built-in dual severity)warn_if/error_ifinternally<Warning>callout about not settingconfig.severityon this testThe test macro configures
warn_if='>=1', error_if='>=2'internally, so dbt automatically warns atwarn_threshold_percentand errors aterror_threshold_percent. Settingconfig.severity: erroroverrides this and turns all warnings into errors.Test plan
🤖 Generated with Claude Code